Draft
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May replace #1515 which is similar. This does the following:
allow_unassigned_to_assignedwhich will either allow or prevent matches from bg=-1 in the design or pointing data to bg != -1 in the pointing or tuneset data. We want to prevent such matches when matching from design to pointing, since the detector types with bg=-1 should always have that value. When matching between pointing and tunesets, we allow bg = -1 to other bg values since some detectors may be assigned bg = -1 in det_cal due to the conditions of when the pointing tune was taken but may be recovered in later tunesets.det_typesofUNRT,SQID, andBAREto always be bg = -1.det_row,det_col, anddet_rhombusoptional for LF.start_timeandstop_timetoupdate_det_matchto simplify epoch handling for detsets. Future update will add epochs to the databases.