Change if statement in preprocess select#1602
Draft
kmharrington wants to merge 1 commit intomasterfrom
Draft
Conversation
Contributor
|
I think it is fine to make this change for all of the processes. I had started trying to standardize the check for saving in this PR for some entries, so we could do something similar. Some processes like source flags might need to have different handling though. |
Contributor
|
Yes we should make that change everywhere |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that passing in
select: Falsedidn't actually cause the select not to happen. The way to have select not to happen is to not have select in the yaml at all.Changing the statement to
if not self.select_cfgsallows both None and False.Should we make this change for all of the preprocess modules?