Skip to content

feat: add the pre-push hook, --committed and the closing run line - #5

Merged
simota merged 2 commits into
mainfrom
feat/rehearsal-cues
Oct 20, 2026
Merged

simota merged 2 commits into
mainfrom
feat/rehearsal-cues

Conversation

@simota

@simota simota commented Oct 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • --install-hook writes a pre-push hook that runs runthrough --committed --quiet push (refuses to overwrite an existing hook)
  • --committed checks out only the HEAD commit; without it, the checkout line counts the uncommitted changes it copied
  • A closing line counts workflows and jobs by result and links the run on the dashboard (--json prints it as an object)
  • --watch prints what changed since the previous run
  • Jobs log ℹ️ notes on what a local run does not reproduce (permissions, environment protection, concurrency across runs); the dashboard shows them
  • The dashboard renders step summaries (safe Markdown subset, no innerHTML) and copies a rehearsal note
  • A run that triggers nothing names the events the workflows do trigger on
  • The site gets a favicon and a share image (docs/og.png, rendered from docs/og.html)

Test plan

  • make check CARGO_FLAGS=--offline (fmt, clippy, unit + e2e tests)
  • New e2e tests: closing line and notes, --committed, empty-run cues
  • Manual: hook blocks then allows a real push; dashboard renders summaries/notes in Chrome
  • cargo test --offline -- --ignored (Docker / port binding) — not yet confirmed

Open questions

  • og:image assumes the site is served at https://simota.github.io/runthrough/
  • The hook blocks the push on exit 2 (internal error) as well as exit 1

- --install-hook writes a pre-push hook that runs `runthrough --committed --quiet push`
- --committed checks out only the HEAD commit instead of the working tree
- a closing line counts workflows and jobs by result and links the dashboard run
- --watch prints what changed since the previous run
- jobs note what a local run does not reproduce (permissions, environment
  protection, concurrency across runs); the dashboard shows the notes
- the dashboard renders step summaries and copies a rehearsal note
- an empty run names the events the workflows do trigger on
- the site gets a favicon and a share image
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T05:01:36.013884Z b1e13e4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b1e13e4cc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/main.rs Outdated
Comment thread src/info.rs Outdated
- --committed reads the repository's workflows, called ones included, from
  the HEAD commit instead of the working tree
- the pre-push hook stops a push of any commit other than HEAD, which it
  does not rehearse
@simota
simota merged commit 4687fbd into main Oct 20, 2026
2 checks passed
@simota
simota deleted the feat/rehearsal-cues branch October 20, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant