Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
@greptile review |
|
@BugBot review |
PR SummaryMedium Risk Overview Refactors workflow execution ( Downgrades many copilot/chat/orchestrator lifecycle logs from Written by Cursor Bugbot for commit 584ac10. This will update automatically on new commits. Configure here. |
Greptile SummaryThis PR delivers two main changes under a single branch: (1) structured logging improvements for the Logging changes:
UI changes:
Notable findings:
Confidence Score: 5/5Safe to merge; all remaining findings are P2 style/informational suggestions with no runtime impact The core logging feature is well-implemented and thoroughly tested. Copilot route fixes are straightforward level downgrades. UI changes are self-contained. No P0/P1 issues found — both flagged items are P2 observations that don't block correct operation. No files require special attention; the two P2 notes in packages/logger/src/index.ts and apps/sim/app/api/workflows/[id]/execute/route.ts are informational only Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant ExecuteRoute as /execute route
participant Logger as Logger (withMetadata)
participant DB
Client->>ExecuteRoute: POST /api/workflows/{id}/execute
Note over ExecuteRoute: reqLogger = logger.withMetadata({requestId, workflowId})
ExecuteRoute->>ExecuteRoute: checkHybridAuth()
Note over ExecuteRoute: executionId = uuidv4()<br/>reqLogger = reqLogger.withMetadata({userId, executionId})
ExecuteRoute->>Logger: reqLogger.info("Starting server-side execution")
ExecuteRoute->>DB: authorizeWorkflow + preprocessExecution
DB-->>ExecuteRoute: workflow record (incl. workspaceId, actorUserId)
Note over ExecuteRoute: reqLogger = reqLogger.withMetadata({workspaceId, userId: actorUserId})
ExecuteRoute->>Logger: reqLogger.info("Preprocessing passed")
ExecuteRoute->>ExecuteRoute: run workflow (SSE or non-SSE)
ExecuteRoute->>Logger: reqLogger.info/error (block events, errors)
ExecuteRoute-->>Client: response
Reviews (2): Last reviewed commit: "improvement(ui): sidebar (#3832)" | Re-trigger Greptile |
#3830) * improvement(sidebar): expand sidebar by hovering and clicking the edge * improvement(sidebar): add keyboard shortcuts for new workflow/task, center search modal, fix edge ARIA * improvement(sidebar): use Tooltip.Shortcut for inline shortcut display * fix(sidebar): change new workflow shortcut from Mod+Shift+W to Mod+Shift+P to avoid browser close-window conflict * fix(hotkeys): fall back to event.code for international keyboard layout compatibility * fix(sidebar): guard add-workflow shortcut with canEdit and isCreatingWorkflow checks
* feat(ui): handle image paste * Fix lint * Fix type error --------- Co-authored-by: Theodore Li <theo@sim.ai>
* feat(files): interactive markdown checkbox toggling in preview * fix(files): handle ordered-list checkboxes and fix index drift * lint * fix(files): remove counter offset that prevented checkbox toggling * fix(files): apply task-list styling to ordered lists too * fix(files): render single pass when interactive to avoid index drift * fix(files): move useMemo above conditional return to fix Rules of Hooks * fix(files): pass content directly to preview when not streaming to avoid stale frame
…sistency (#3831) * improvement(home): position @ mention popup at caret and fix icon consistency * fix(home): pin mirror div to document origin and guard button anchor * chore(auth): restore hybrid.ts to staging
|
@greptile review |
Summary
We need additional observability into our system, even for successful calls.
Add additional logs for the /execute endpoint with metadata for user id, workflow id, workspace id, execution id. Reverted change to upgrade mothership chat logs to error.
I upgraded our logging system to INFO, so all logs should start showing up.
New formatting:
Type of Change
Testing
Ran workflow execution and validated new metadata logs are shown
Checklist
Screenshots/Videos