Repository navigation
fix(logs): mark withheld trace span content so logs query stops reporting it as missing - #9314
Conversation
…ting it as missing When secret projection omits a span's content field or falls back to structural-only spans, it now sets `contentWithheld: true` on the span. The v2 log contract documents the marker, and `logs query` reports a withheld note (and a `contentWithheld` count) instead of "path not found on span", and keeps such runs under --where rather than silently filtering them out.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
 [Medium impact] The PR appears safe to merge; no new blocking issue was found. SummaryThe PR marks trace spans when secret projection withholds content.
Reviews (3) · Last reviewed commit: "test(logs): give the legacy tool-call fi..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Turn on auto-fix | Re-trigger cubic
|
@greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 8 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 8 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Turn on auto-fix | Re-trigger cubic
Summary
logs queryansweredpath not found on spanfor every such run, which is wrong (the value exists, it was withheld) and agents acted on itcontentWithheld: trueon a span when it omits one of its content fields (input/output/thinking/errorMessage) and on every span of a structural-only fallback (incomplete registry, projection failure, failed post-transform invariant). Boolean marker only; no content is restored and no projection is bypassedLogTraceSpanin the v2 log contract documents it (additive, optional). Regeneratedopenapi-v2-logs.jsonand the CLI's generated v2 APIlogs query: an unresolved path on a withheld span getsnote: 'span content withheld by the log projection; value unknown'and counts toward a newcontentWithheldsummary field. Under--where, those runs stay in the result with the note instead of being silently counted asfilteredOut. Structural paths (status,duration) still resolve normallyType of Change
Testing
trace-secret-projection.test.ts: structural fallback (incomplete registry, matcher failure, invariant failure) marks spans and children; a field omission marks the span; a cleanly projected span stays unmarked. Red on pre-fix codeengines.test.ts: withheld span reports the withheld note and count, not path-not-found; structural paths still answer;--wherekeeps withheld runs. Red on pre-fix codetrace-store.test.ts,logging-session.test.ts,app/api/v2/logssuites pass;check:openapi,check:cli-api,check:cli-docs,check:mcp-operations,check:comment-hygiene,check:test-patterns, lint. Full type-check/audits left to CIChecklist
test-auditauthoring gate)