Repository navigation
fix(workflows): accept legacy input field types instead of rejecting them - #9350
Merged
Merged
Conversation
…them Stored Start inputs carry a long tail of types outside the editor's list (json, legacy widget names). Until the shared run schema began throwing on them, they ran with the executor passing values through unchanged. Keep that contract end to end: an unknown type accepts any value in run validation and advertises no type over MCP, the save path stores input-format rows unchanged again, and the executor no longer reinterprets json values, so deployed runs behave exactly as they did. files stays an alias of file[], which both sides already apply.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
There was a problem hiding this comment.
No issues found across 8 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Turn on auto-fix | Re-trigger cubic
Contributor
[Medium impact] This PR appears safe to merge. SummaryRestores support for saved workflow inputs with legacy types.
No actionable issues found. The
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
json, legacy widget names likeshort-input,textarea,select). Before the shared run schema started throwing on them, they ran with the executor passing values through unchanged.input-formatcheck, so edits to workflows carrying legacy types are not rejected and rows are stored unchanged.jsoncoercion alias, so deployed runs behave exactly as before.jsonis treated like any other legacy type on every side;filesstays an alias offile[], which both sides already apply.Type of Change
Testing
bun run lint,check:unused-exports,check:comment-hygiene,check:test-patterns,check:client-boundary,check:boundaries,check:utils,check:source-conventions.Checklist
test-auditauthoring gate)