Skip to content

Review of bulk run creation functionality#22

Merged
kzscisoft merged 19 commits into
mainfrom
dev
Sep 30, 2025
Merged

Review of bulk run creation functionality#22
kzscisoft merged 19 commits into
mainfrom
dev

Conversation

@wk9874

@wk9874 wk9874 commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@wk9874 wk9874 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add detail to the README and raise a PR in the docs repo

Also can we add Parquet support?

Comment thread pyproject.toml Outdated
Comment thread src/simvue_cli/actions.py Outdated
Comment thread src/simvue_cli/actions.py
Comment thread src/simvue_cli/actions.py
Comment thread src/simvue_cli/cli/__init__.py
Comment thread src/simvue_cli/push/json.py
Comment thread src/simvue_cli/push/json.py Outdated
Comment thread src/simvue_cli/push/core.py Outdated
Comment thread tests/test_command_line_interface.py Outdated
Comment thread tests/test_command_line_interface.py Outdated

@wk9874 wk9874 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things left to address

Tested it with >20,000 lines of a metadata CSV file using Will's data and seems to work well!
Also happy with the name of the command now :)

Comment thread src/simvue_cli/push/core.py
Comment thread src/simvue_cli/cli/__init__.py Outdated
"--metadata",
"global_metadata",
type=JSONType,
help="Metadata to append to all runs.",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May want to note here that it expects a dictionary surrounded by quotes

Comment thread src/simvue_cli/push/core.py
Comment thread tests/test_command_line_interface.py Outdated
_folder_id = result.stdout.strip()
assert _folder_id
_folder = Folder(identifier=_folder_id, return_stats=True)
assert _folder.to_dict()["runs"] == 1000, f"Expected 1000 runs in {_folder_id} but got {_folder.to_dict()['runs']}"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 40,000 right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I used monkeypatch to reduce the threshold for faster test

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think you did...

@pytest.fixture
def create_metadata_csv() -> pathlib.Path:
    N_RUNS: int = 40000

And either way, you should test with > 20k runs in a batch to check the chunking works

@wk9874

wk9874 commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

Lots of tests have errors, am working on fixing those

Push no longer seems to work at all after latest commit :/

@wk9874

wk9874 commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

Also push_json_runs doesnt support name, but the CLI passes it through anyway, leading to:

        if input_file.suffix == ".json":
>           _folder_ids = simvue_cli.actions.push_json_runs(
                input_file,
                public_visible=public_visible,
                tenant_visible=tenant_visible,
                user_list=user_list,
                **kwargs,
            )
E           TypeError: push_json_runs() got an unexpected keyword argument 'name'

@kzscisoft kzscisoft self-requested a review September 29, 2025 07:15
@kzscisoft kzscisoft merged commit 97f2b63 into main Sep 30, 2025
6 checks passed
@kzscisoft kzscisoft linked an issue Oct 10, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bulk run creation from file

2 participants