Skip to content

[DONE] Split create and destruction EMC Methods. API/Methods only#1036

Open
MaPePeR wants to merge 14 commits into
sinkillerj:masterfrom
MaPePeR:splitBuyAndSellApiOnly
Open

[DONE] Split create and destruction EMC Methods. API/Methods only#1036
MaPePeR wants to merge 14 commits into
sinkillerj:masterfrom
MaPePeR:splitBuyAndSellApiOnly

Conversation

@MaPePeR
Copy link
Copy Markdown
Contributor

@MaPePeR MaPePeR commented Oct 4, 2015

Also contains #984 (Use this link to see the new changes made on top of that PR)

Cherry picked some commits from #992/#1015.

  • Splits calls to getEMC into a version for creation and a version for destruction.
  • Adds API methods to check for creation and destruction EMC values.

The only difference is, that destruction EMC honors enchantment bonus and destruction multiplier for now. (Which should fix #988 and fix #1047 as a side effect)

Conflicts:
	src/main/java/moze_intel/projecte/gameObjs/container/inventory/TransmutationInventory.java
@MaPePeR MaPePeR changed the title Split create and destruction EMC Methods. API/Methods only [DONE] Split create and destruction EMC Methods. API/Methods only Oct 11, 2015
@MaPePeR
Copy link
Copy Markdown
Contributor Author

MaPePeR commented Oct 11, 2015

I think we even might need another method that does ItemStack -> ItemStack likegetCreatedItem, which does the nbt_whitelist lookup and returns an undamaged tool when given a damaged tool. Thoughts? (Still think we can merge this how it is right now)

Conflicts:
	src/main/java/moze_intel/projecte/playerData/Transmutation.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant