Treat missing a=fmtp as defaults for AMR#2141
Closed
alexbakker wants to merge 1 commit into
Closed
Conversation
rfuchs
reviewed
Jul 19, 2026
| // offer has octet-align=0, answer omits fmtp -> should match | ||
| start(); | ||
| sdp_pt(0, PCMU, 8000); | ||
| transcode(AMR-WB/16000/1///octet-align=0); |
Member
There was a problem hiding this comment.
doesn't compile because the // is interpreted as a comment
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set.
Contributor
Author
|
@rfuchs I must have forgotten to push the latest revision. Sorry about that. The tests should pass now. |
Member
|
Much better, thank you |
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 22, 2026
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set. Closes #2141 Change-Id: I1371cb1fdb9354746a4019477845d777e619a2f6 (cherry picked from commit 702ccec)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 22, 2026
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set. Closes #2141 Change-Id: I1371cb1fdb9354746a4019477845d777e619a2f6 (cherry picked from commit 702ccec) (cherry picked from commit 84d6296)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 22, 2026
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set. Closes #2141 Change-Id: I1371cb1fdb9354746a4019477845d777e619a2f6 (cherry picked from commit 702ccec) (cherry picked from commit 84d6296)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 22, 2026
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set. Closes #2141 Change-Id: I1371cb1fdb9354746a4019477845d777e619a2f6 (cherry picked from commit 702ccec) (cherry picked from commit 84d6296)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 22, 2026
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set. Closes #2141 Change-Id: I1371cb1fdb9354746a4019477845d777e619a2f6 (cherry picked from commit 702ccec) (cherry picked from commit 84d6296)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 22, 2026
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set. Closes #2141 Change-Id: I1371cb1fdb9354746a4019477845d777e619a2f6 (cherry picked from commit 702ccec) (cherry picked from commit 84d6296) (cherry picked from commit b7eec52)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 22, 2026
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set. Closes #2141 Change-Id: I1371cb1fdb9354746a4019477845d777e619a2f6 (cherry picked from commit 702ccec) (cherry picked from commit 84d6296) (cherry picked from commit 724ef04)
sipwise-jenkins
pushed a commit
that referenced
this pull request
Jul 22, 2026
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no ``a=fmtp`` attribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec". This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set. Closes #2141 Change-Id: I1371cb1fdb9354746a4019477845d777e619a2f6 (cherry picked from commit 702ccec) (cherry picked from commit 84d6296) (cherry picked from commit a3e8240)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per RFC 4867 section 8.1, absent fmtp parameters imply defaults (bandwidth-efficient mode, no CRC, no robust-sorting, no interleaving). Previously, codec matching was rejected when either side had no
a=fmtpattribute for the AMR payload type, causing AMR to be dropped as a "stray answer codec".This patch changes this behavior to instead "parse" fmtp even when absent so that the format struct is populated with zero-initialized defaults and fmtp_parsed is set.