recording-daemon: lifecycle notification events

[goolanceman]

Summary

Extends rtpengine-recording notifications from the historical finished-only path to a configurable call/stream lifecycle event set, while remaining backward compatible.

Events (notify-events CSV)

Token	Event name
opened	recording_file_opened
started	recording_started
finished (default)	recording_finished
discarded	recording_discarded
failed	recording_failed
call-started	call_recording_started
call-finished	call_recording_finished
call-discarded	call_recording_discarded
all	all of the above

Default remains finished only so existing deployments are unchanged.

New options

• notify-events — CSV list (default finished)
• notify-json — POST JSON body via json-glib
• notify-no-metadata — omit call metadata from payloads
• notify-command-format — legacy | extended | json-env
• notify-queue-limit — bound non-terminal queue depth (default 1000; 0 = unlimited). Terminal events are always accepted.

Design

• Keeps upstream action-based notify model (notif_action_t / notif_req_t) and lib/http.c helpers
• Pure event helpers in notify_events.c (shared with unit tests)
• Stream hooks in output.c; call hooks in metafile.c / packet.c
• Snapshots strings into notif_req before queueing (workers never touch live objects)
• Metrics logged on shutdown: enqueued / success / retry / giveup / dropped

Tests

• Unit: t/test-notify-events.c — PASS
• E2E smoke: t/notify_e2e/ temp Python HTTP receiver + metafile lifecycle — E2E_NOTIFY_OK
  • Built/ran in Docker
  • Received call_recording_finished with JSON body + lifecycle headers

Docs

• docs/rtpengine-recording.md
• etc/rtpengine-recording.conf

Example

notify-uri = https://example.com/rec/events
notify-events = opened,started,finished,discarded,failed,call-started,call-finished,call-discarded
notify-json = true
notify-concurrency = 5
notify-retries = 10

Compatibility

• Default config behavior is identical to previous finished-only notifications
• Legacy notify-command argv (path, db_id) preserved when notify-command-format=legacy

---

I used an AI assistant to help with some of the repetitive work (e.g. scaffolding, draft text), but the architecture, behaviour, and all final code changes were reviewed, adapted, and validated by me. The goal is to speed up the mechanical parts while still having a human developer take responsibility for correctness, style, and alignment with rtpengine 's conventions. Feedback is very welcome and I'll iterate on the implementation as needed.

[rfuchs]

This is all AI generated, isn't it

[goolanceman]

This is all AI generated, isn't it

Good eye 🙂
I did use an AI assistant to help draft parts of this (especially the docs/text), but I've reviewed and adjusted everything myself and verified the code and tests. I'm fully responsible for the changes here, so if anything looks off, please call it out and I'll fix it.