Generate simulation data for SPECTRUM/IMAGE attributes - #159
Open
kmadisa wants to merge 2 commits into
Open
Conversation
…es that are python primitive types (float in this case) which are appropriate for attributes with a SCALAR data format. This is a problem for the attrbiutes with more complex data formats, SPECTRUM/IMAGE. When reading an attribute, the quantity returns a primitive type which PyTango is not expecting, therefore resulting in the error, 'Wrong Python type for attribute... Expected a sequence'. This change here allows us to cater for the complex data formats. The method next_val now generates the simulation data according to the data format, given by the meta dictionary. Resolves #157 Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
…LAR. It is implied to be 1. I have set default values for the max_dim_x and max_dim_y properties, respectively, when the are not provided. Resolves #157 Signed-off-by: Katleho Madisa <katleho.madisa47@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GaussianSlewLimitedquantity class only generated simulation values that are python primitive types (float in this case) which are appropriate for attributes with a SCALAR data format.This is a problem for the attrbiutes with more complex data formats,
SPECTRUM/IMAGE. When reading an attribute, the quantity returns a primitive type which PyTango is not expecting, therefore resulting in the error,Wrong Python type for attribute... Expected a sequence. This change here allows us to cater for the complex data formats. The methodnext_valnow generates the simulation data according to the data format, given by themetadictionary.Resolves #157
Signed-off-by: Katleho Madisa katleho.madisa47@gmail.com
Screenshots or code snippets (if appropriate):
N/A
Definition of Done Checklist
SKA-JIRA: 442