fix: summarize results (#26)#27
Closed
schnellert wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the "Argument list too long" failure in the Summarize results step of the build-docker-image composite action (issue #26). Because environment variables passed to a subprocess count toward Linux's ARG_MAX, a large metadata output from docker/build-push-action could cause Node to fail to start. The fix removes the METADATA env var and instead inlines the JSON output directly into the github-script source (which is written to a temp file, bypassing the arg/env size limit).
Changes:
- Removed the
env.METADATAmapping from theSummarize resultsstep. - Replaced
JSON.parse(process.env.METADATA)with direct GitHub Actions template interpolation ofsteps.build.outputs.metadata(with a""fallback).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+97
to
99
| const metadata = ${{ steps.build.outputs.metadata || '""' }}; | ||
| const digest = metadata['containerimage.digest']; | ||
| const [image, ...images] = metadata['image.name'].split(','); |
Member
Author
|
Doesn't solve the actual issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26