Devesh/sk 2814 invoke connection fixes#323
Merged
Devesh-Skyflow merged 3 commits intoMay 25, 2026
Merged
Conversation
…uestId" This reverts commit 8c292d2.
…equest-id header" This reverts commit 2740de4.
URL encoding path/query params is a breaking change for users who pre-encode values (double-encoding), and Go SDK v1/v2 does raw substitution with no encoding — keep consistent. Raw string body support is not confirmed by the Connections API docs; the gateway needs structured (JSON/form) bodies for token replacement, so raw strings would forward tokens unreplaced. Remove to avoid misleading users. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Devesh-Skyflow
added a commit
that referenced
this pull request
May 25, 2026
* Devesh/sk 2814 invoke connection fixes (#323) * Revert "test: fix testSendRequestWithNullRequestId to assert null requestId" This reverts commit 8c292d2. * Revert "fix: do not generate SDK-side requestId when server omits x-request-id header" This reverts commit 2740de4. * revert: remove URL encoding and raw body from InvokeConnection URL encoding path/query params is a breaking change for users who pre-encode values (double-encoding), and Go SDK v1/v2 does raw substitution with no encoding — keep consistent. Raw string body support is not confirmed by the Connections API docs; the gateway needs structured (JSON/form) bodies for token replacement, so raw strings would forward tokens unreplaced. Remove to avoid misleading users. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * [AUTOMATED] Private Release 3.0.0-beta.11-dev-c859136 --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Devesh-Skyflow <Devesh-Skyflow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start with a concise summary of the PR. The first three sections are required. The questions present in each section is there to help you guide you what to add. They are meant to be overwritten by your comments.
Why
Goal
Testing
Tech debt