Skip to content

Devesh/fix v1 release#333

Merged
Devesh-Skyflow merged 3 commits into
v1from
devesh/fix-v1-release
May 29, 2026
Merged

Devesh/fix v1 release#333
Devesh-Skyflow merged 3 commits into
v1from
devesh/fix-v1-release

Conversation

@Devesh-Skyflow
Copy link
Copy Markdown
Collaborator

Start with a concise summary of the PR. The first three sections are required. The questions present in each section is there to help you guide you what to add. They are meant to be overwritten by your comments.

Why

  • Why are you making the change?
  • What is the underlying issue that you are trying to case, in case of fix?
  • Why is it needed by the feature you are working on?
  • What is the intent behind making the change?

Goal

  • What is the intended outcome?
  • What part of the feature should start working?
  • What are the non-goals or will be covered in future PR?

Testing

  • How was the code tested?
  • If you haven't written unit tests, why?
  • What more testing is needed? Do you intend to manually test it after deployment?
  • Do you have any concerns if this changed is released to prod?

Tech debt

  • Is the PR adding to tech debt in any way?
  • Are you addressing some Tech debt in this PR?
  • If both the above are false, feel free to remove this section.

Devesh-Skyflow and others added 3 commits May 27, 2026 18:06
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Internal (JFrog) releases should only trigger on branch pushes, not tags.
Tags are reserved for public Maven Central releases.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add target-branch input to shared workflow so the post-release pom.xml
commit is pushed to the correct branch (v1 for 1.x.x tags, main for
others) instead of failing with 'not on a branch' error.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@Devesh-Skyflow Devesh-Skyflow merged commit d43f3c6 into v1 May 29, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant