SK-2708 fix readme and sample gaps#320
Open
skyflow-bharti wants to merge 1 commit into
Open
Conversation
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SK-2708: Fix README and sample gaps
Summary
README.mdOptionsclasses in samples to show every available setter as commented alternatives, following thefile-upload.tspatternREADME changes
New sections added
Skyflowclass public methods (addVaultConfig,updateVaultConfig,getVaultConfig,removeVaultConfig,addConnectionConfig,updateConnectionConfig,getConnectionConfig,removeConnectionConfig,setLogLevel,getLogLevel,updateSkyflowCredentials,getSkyflowCredentials) with code examplesConnectionConfigshape (connectionId,connectionUrl, optionalcredentials)SkyflowRecordError) — documents the error shape returned inresponse.errorsarraysFileInputExisting sections expanded
InsertOptions— addedsetTokens,setHomogeneous,setTokenMode+ fullTokenModeenum tableUpdateOptions— added code example usingUpdateOptions+ reference table for all 3 settersGetOptions— added reference table for all 9 setters +OrderByEnumtableFileUploadOptions— added reference table for all 5 setters (setFilePath,setBase64,setFileName,setFileObject,setSkyflowId)DeidentifyFileOptions— added reference table for all 15 setters including image, audio, PDF, andBleepclass settersTokenFormat— addedsetVaultToken,setEntityUniqueCounter,setEntityOnlyalongside existingsetDefaultgenerateBearerToken/generateBearerTokenFromCreds— documentedBearerTokenOptionsandGenerateTokenOptionstypesgenerateSignedDataTokens— mergedgenerateSignedDataTokensFromCredsinto same section withSignedDataTokensOptionstypeVaultConfig— added optionalcredentialsfieldisExpired— added usage exampleBug fixes
DELETEfromRequestMethodvalues list (not in the enum)optionsTexttypo →optionsin De-identify Text exampleupdatedCredentials,updatedConnectionConfig,newCredentials)credsundefined variable in credential sub-types examplehttp_code→httpCodein error handling example (camelCase is the current API)Sample changes
samples/README.mdclient-operations.ts,credentials-options.ts,data-residency.ts,deidentify-file-with-filepath.ts,deidentify-file-with-filepath-async.tsinsert-byot.tslabel from"Upsert operations"→"Insert with bring-your-own tokens (BYOT)"Misleading placeholder values fixed
Replaced
skyflow_id-prefixed placeholder strings that looked like the deprecatedskyflow_idAPI field:insert-byot.ts'skyflow_id1'/'skyflow_id2'→'<TOKEN_1>'/'<TOKEN_2>';token: 'bearer'→'<BEARER_TOKEN>'detokenzie-records.tstoken: 'token'→'<BEARER_TOKEN>'delete-records.ts'skyflow_id1–3'→'<SKYFLOW_ID_1–3>'credentials-options.ts'skyflow_id1–6'→'<SKYFLOW_ID_1–6>'Internal ticket references removed
update-record.ts— removed// SK-2812:commentget-records.ts— removed// NEW API (SK-2812):comment and deprecatedsetDownloadURLreferenceDeprecated field reference fixed
deidentify-file-with-filepath-async.ts—error.error?.http_code→error.error?.httpCodeMissing options added (as commented alternatives)
file-upload.tssetBase64+setFileName(Option B),setFileObject(Option C)insert-records.tssetContinueOnError,setUpsertColumn,setHomogeneousupdate-record.tssetTokens,setTokenModeget-records.tssetRedactionType,setFields,setOffset,setLimit,setOrderBy,setDownloadUrl,setColumnName/setColumnValuesget-column-values.tssetRedactionType,setFields,setOffset,setLimit,setOrderBydeidentify-text.tssetVaultToken,setEntityUniqueCounter,setEntityOnlyonTokenFormat; fixedoptionsText→optionsTest plan
http_code,skyflow_id,request_ID) remain in active sample codesamples/README.mdlinks resolve to existing files