Add missing style attribute to RichTextElementParts.Date & friends#1882
Merged
Conversation
According to the docs[1] and Node SDK[2] all rich text element parts support the `style` attribute, so I've added it where missing. [1]: https://docs.slack.dev/reference/block-kit/blocks/rich-text-block#date-element-type [2]: https://github.com/slackapi/node-slack-sdk/blob/b12a62f15e54b076183844493fe3677dd3a702b5/packages/types/src/block-kit/block-elements.ts#L833
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1882 +/- ##
==========================================
- Coverage 84.13% 84.12% -0.02%
==========================================
Files 117 117
Lines 13337 13340 +3
==========================================
+ Hits 11221 11222 +1
- Misses 2116 2118 +2 ☔ View full report in Codecov by Sentry. |
vegeris
approved these changes
May 29, 2026
Contributor
vegeris
left a comment
There was a problem hiding this comment.
Thanks for making this update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that the
styleattribute was missing when I tried to make a date bold.Testing
Category
/docs(Documents)/tutorial(PythOnBoardingBot tutorial)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.