Handle circular fragment references#102
Open
ivome wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect and skip circular fragment spreads during complexity analysis to prevent infinite recursion when evaluating invalid queries.
nodeComplexity()now tracks fragment names on the active spread path via a backtrackingSet. When a fragment spread references a fragment already on that path, the spread is skipped instead of recursing indefinitely. This is a defense-in-depth measure alongside GraphQL'sNoFragmentCyclesRule— graphql-js runs validation rules in parallel without early abort, so the complexity visitor could still recurse into a cycle before the cycle error is reported.For acyclic queries, behavior is unchanged: the set is only populated during fragment descent and cleared on the way back up, so sibling spreads and diamond patterns still count correctly. The backtracking approach keeps traversal O(n) in time and memory (no per-descent
Setcopies).