Keys API for C++/JS/Python#11098
Merged
LeonMatthes merged 5 commits intoslint-ui:masterfrom Apr 2, 2026
Merged
Conversation
ogoffart
reviewed
Mar 24, 2026
ogoffart
reviewed
Mar 24, 2026
LeonMatthes
force-pushed
the
lm/102-keys-language-bindings
branch
from
333f071 to
c1529b1
Compare
Member
|
Python and JS side looks good to me. Thanks a lot ❤️ |
LeonMatthes
force-pushed
the
lm/102-keys-language-bindings
branch
from
c1529b1 to
b01bd10
Compare
LeonMatthes
force-pushed
the
lm/102-keys-language-bindings
branch
2 times, most recently
from
f7aebbd to
0715cb0
Compare
LeonMatthes
force-pushed
the
lm/102-keys-language-bindings
branch
from
0715cb0 to
ccb1718
Compare
LeonMatthes
force-pushed
the
lm/102-keys-language-bindings
branch
from
ccb1718 to
547bdc5
Compare
ogoffart
approved these changes
Apr 2, 2026
Member
ogoffart
left a comment
ogoffart
left a comment
There was a problem hiding this comment.
I'm still a bit concerned to see this "empty" type in the public API at this point, but let's merge this so we can progress
LeonMatthes
force-pushed
the
lm/102-keys-language-bindings
branch
from
547bdc5 to
f376db0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.