Merged
Conversation
LeonMatthes
force-pushed
the
lm/102-menu-shortcuts
branch
2 times, most recently
from
47cedb7 to
e72fce1
Compare
LeonMatthes
force-pushed
the
lm/102-menu-shortcuts
branch
4 times, most recently
from
a8257b0 to
8c7d4dc
Compare
tronical
reviewed
Apr 1, 2026
LeonMatthes
force-pushed
the
lm/102-menu-shortcuts
branch
2 times, most recently
from
3f49006 to
84d1d15
Compare
LeonMatthes
force-pushed
the
lm/102-menu-shortcuts
branch
from
84d1d15 to
2154e98
Compare
tronical
reviewed
Apr 2, 2026
ogoffart
approved these changes
Apr 2, 2026
ogoffart
reviewed
Apr 2, 2026
Currently this is only supported on MenuItems that are placed in a MenuBar, not in ContextMenuArea.
From prior testing we have found that e.g. this shortcut: ```slint @keys(Control + Equals) ``` Would be translated by macOS to: * on a German keyboard layout, which doesn't make sense based on the definition in Slint. We want to keep consistency between platforms. Slint-native shortcut localization is on our roadmap anyhow.
LeonMatthes
force-pushed
the
lm/102-menu-shortcuts
branch
from
2154e98 to
90229ec
Compare
Member
|
This PR relates to #102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds shortcut support in menu items that are part of the menu bar.
It does not add this yet for the context menu area, as this needs more access by the
ContextMenuto handle the shortcuts.ChangeLog: Supports shortcuts in MenuItems that are part of the MenuBar
Fixes #xxxorCloses #xxxChangeLog: ...