tests: widgets_datepicker_* tests now run#11130
Merged
ogoffart merged 2 commits intoslint-ui:masterfrom Apr 1, 2026
Merged
Conversation
LeonMatthes
approved these changes
Mar 25, 2026
Member
LeonMatthes
left a comment
LeonMatthes
left a comment
There was a problem hiding this comment.
🤦 Thanks for finding this!
Collaborator
Author
|
Looks like some things need fixing… |
0x6e
force-pushed
the
feature/fix-datepicker-test
branch
from
01a93a0 to
c52c631
Compare
Collaborator
Author
|
Rebased... I couldn't reproduce the CI failure locally. |
Collaborator
Author
|
Looks like I need to try harder... |
Collaborator
Author
|
I haven't fully understood the patch that Claude came up with, it's late... but wanted to see what the CI said. |
The Rust code block for the Rust test driver was missing a closing "```" which meant that the test was not being run.
When link_two_way_with_map_to_common_property replaces a property's binding, it must transfer the dependency list from the old binding's BindingHolder back to the property handle. Previously, the handle was simply set to 0, orphaning the dependency list. When the old binding was later freed via BindingMapper::drop, the BindingHolder.dependencies (Cell<usize>) received a trivial drop instead of a proper DependencyListHead::drop, leaving DependencyNodes with dangling prev pointers that caused a debug_assert panic on drop. Extract a detach_binding() helper on PropertyHandle that transfers the dependency list from a binding back to the handle without dropping the binding — the dependency-transfer portion of remove_binding(), also handling the CONSTANT_PROPERTY_SENTINEL case. Refactor remove_binding() to use detach_binding() + vtable.drop, and call detach_binding() in link_two_way_with_map_to_common_property before replacing the binding. Add a regression test that arranges drop order so a PropertyTracker's dependency node outlives the old binding, which would trigger a panic in DependencyNode::debug_assert_valid without the fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
0x6e
force-pushed
the
feature/fix-datepicker-test
branch
from
6bea244 to
b4f6818
Compare
Collaborator
Author
|
I've reviewed Claude's patch, requested some changes and added a test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust code block for the Rust test driver was missing a closing "```" which meant that the test was not being run.