Skip to content

OR-Tools v9.12: Use fixed intervals#175

Draft
dop-amin wants to merge 4 commits into
mainfrom
ortools_9_12_fixed_ivals
Draft

OR-Tools v9.12: Use fixed intervals#175
dop-amin wants to merge 4 commits into
mainfrom
ortools_9_12_fixed_ivals

Conversation

@dop-amin
Copy link
Copy Markdown
Collaborator

This PR is based on #172.

According to a comment by Laurent Perron, this is supposed to improve efficiency of solving the constraint problem.

No thorough investigation about efficiency gains in our case has been done.

@mkannwischer
Copy link
Copy Markdown
Collaborator

@dop-amin, are you planning to investigate the performance impact of this, or what are we going to do with this PR?

@dop-amin
Copy link
Copy Markdown
Collaborator Author

I think using this feature of "newer" ortools versions is the right thing to do as it gives more information to the solver about the structure of the problem. I would think there is almost no way this could hurt the performance. I was waiting to investigate further until we've settled on a version of ortools back then. I don't have the time to follow up on the testing anymore.

Maybe it's enough to rebase this and roughly check CI times before merging.

@mkannwischer
Copy link
Copy Markdown
Collaborator

I think using this feature of "newer" ortools versions is the right thing to do as it gives more information to the solver about the structure of the problem. I would think there is almost no way this could hurt the performance. I was waiting to investigate further until we've settled on a version of ortools back then. I don't have the time to follow up on the testing anymore.

Maybe it's enough to rebase this and roughly check CI times before merging.

Sounds like a good plan to me. Can you rebase it, please?

@dop-amin
Copy link
Copy Markdown
Collaborator Author

I figured this feature seems to be new since 9.10(?) so merging now with 9.7 is incompatible.
We could leave this as a draft until we update the default or-tools version eventually or close for now and have an issue about this. I think keeping separate paths in the code for either would be a terrible thing to do.

@mkannwischer
Copy link
Copy Markdown
Collaborator

I figured this feature seems to be new since 9.10(?) so merging now with 9.7 is incompatible. We could leave this as a draft until we update the default or-tools version eventually or close for now and have an issue about this. I think keeping separate paths in the code for either would be a terrible thing to do.

Agreed - we should not have separete paths for different ortools versions.
We can just keep this open for now.

@mkannwischer mkannwischer force-pushed the ortools_9_12_fixed_ivals branch 2 times, most recently from 3e1a852 to 1b19589 Compare April 13, 2026 13:38
dop-amin and others added 4 commits April 13, 2026 15:45
* According to a comment by lperron, this is supposed to improve efficiency of solving the constraint problem
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
@mkannwischer mkannwischer force-pushed the ortools_9_12_fixed_ivals branch from 1b19589 to 1f2eb54 Compare April 13, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants