This repository was archived by the owner on May 30, 2026. It is now read-only.
fix(reducer): preserve relationship IDs when backend sends null#934
Open
RajanChavada wants to merge 1 commit into
Open
fix(reducer): preserve relationship IDs when backend sends null#934RajanChavada wants to merge 1 commit into
RajanChavada wants to merge 1 commit into
Conversation
Use `??` operator for parent_id, link_type, and root_chat_id in applyRestoredThread to match the pattern used in the snapshot event handler (lines 1331-1333). Previously, valueOrExisting would allow null to overwrite existing relationship IDs, breaking parent/child chat relationships when the backend sent null for these fields. The ?? operator correctly treats null as "keep existing value" rather than "overwrite with null", consistent with how SSE snapshot events handle the same backend fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
??operator for parent_id, link_type, and root_chat_id in applyRestoredThread to match the pattern used in the snapshot event handler (lines 1331-1333).Previously, valueOrExisting would allow null to overwrite existing relationship IDs, breaking parent/child chat relationships when the backend sent null for these fields.
The ?? operator correctly treats null as "keep existing value" rather than "overwrite with null", consistent with how SSE snapshot events handle the same backend fields.