fix: tolerate startxref offset inside xref keyword#798
Closed
vitormattos wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This was referenced Apr 24, 2026
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Author
|
Added an extra regression sample from the same investigation: PullRequest794.pdf (veraPDF 6-6-2-3-2-t01-pass-c). This complements existing coverage and confirms the same startxref tolerance fix across another real-world file. |
Author
|
This standalone PR has been restacked into the RawDataParser consolidation chain to reduce conflict hotspots in shared test files.\n\nSuperseded-by chain:\n- upstream base: #796\n- fork stack (PR797 replay): https://github.com/vitormattos/pdfparser/pull/26\n- fork stack (this PR798 replay): https://github.com/vitormattos/pdfparser/pull/27\n\nClosing this standalone PR to keep a single merge path per source-file group. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startxrefpoints one byte inside thexrefkeyword (ref) or includes leading whitespace drift.Reproduction
pdfinfobut failed in parser withInvalid object reference for $obj..testParseFileWhenStartxrefPointsToLeadingWhitespaceInXrefStream.Changes
RawDataParser::getXrefData()now computes and uses a whitespace-adjustedstartxrefoffset.refinstead ofxref.samples/bugs/PullRequestStartxrefWhitespaceXrefStream.pdf.