fix(rawdata): recover malformed xref_command_missing startxref path#815
Closed
vitormattos wants to merge 1 commit into
Closed
fix(rawdata): recover malformed xref_command_missing startxref path#815vitormattos wants to merge 1 commit into
vitormattos wants to merge 1 commit into
Conversation
Author
|
Closing as duplicate/superseded: this fix was incorporated into PR #796 (branch fix/invalid-object-reference-tolerant-parser), including regression test and fixture, to avoid parallel PRs touching RawDataParser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixed in this PR
Some malformed PDFs contain an unusable
startxreftarget and/or a missing usable xref command near the advertised offset.In this scenario, parsing failed with
Unable to find xref.This PR improves
RawDataParserrecovery by:decodeXref(not only exactxrefkeyword offsets),startxrefis missing or unusable,Fixture(s) and source
samples/bugs/rawdata/PullRequest815-xref-command-missing.pdfdev-tools/pdf-dataset/pdfs/pdfjs/xref_command_missing.pdfTests
Focused gate executed with filter:
RawDataParserTest::testParseRawDataIssuePullRequest815XrefCommandMissingResult:
OK (1 test, 1 assertion)Note to maintainer
You can merge this PR directly, or use it as a reviewable base fix and merge through the integration branch/aggregator flow.