Quality of life netherportal fix#1337
Merged
sylvessa merged 4 commits intosmartcmd:mainfrom Apr 3, 2026
Merged
Conversation
fixed x axis portal with obsidian on z axis
removed PortalTile:: from PortalTile::validPortalFrame
Collaborator
Minecraft.Client_rz2wEugfYz.mp4??? Why does it place an emerald ore |
Contributor
Author
|
O, left some debug code |
Contributor
Author
|
Should be fixed now. |
Us3ful-dev
changed the title
Collaborator
|
thank you for this, and sorry it took so long to review lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accidently removed the old netherportal fix so reopened it here with the bugs fixed.
Changes
Does two checks if two portals might be posible.
Previous Behavior
An obsidian next to the portal blocks the portal from lighting.
Root Cause
If two portals are posible the game does no check.
New Behavior
One of the posible portals lights or does not get blocked by the extera obsidian.
Fix Implementation
Check if two portals might be posible and then check both (exept when first already works)
AI Use Disclosure
No AI was used.
Related Issues