SNOW-3538315: add type annotations to DataFrame telemetry decorators#4230
Open
gitovska wants to merge 1 commit into
Open
SNOW-3538315: add type annotations to DataFrame telemetry decorators#4230gitovska wants to merge 1 commit into
gitovska wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3538315
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Three telemetry decorators (df_api_usage, df_to_relational_group_df_api_usage, relational_group_df_api_usage) had no type annotations, causing all wrapped DataFrame and RelationalGroupedDataFrame methods to return Unknown under strict type checkers (pyright, ty).
Added _FuncT = TypeVar("_FuncT", bound=Callable[..., Any]) and annotated all three decorators as (func: _FuncT) -> _FuncT, following the pattern used in the existing publicapi decorator in utils.py
Type annotation only. No behavioural change.