SNOW-3556267: Fix AttributeError when write_pandas receives list name…#4236
Open
JonathanStefanov wants to merge 3 commits into
Open
SNOW-3556267: Fix AttributeError when write_pandas receives list name…#4236JonathanStefanov wants to merge 3 commits into
JonathanStefanov wants to merge 3 commits into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Eagleseb
reviewed
May 22, 2026
Eagleseb
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3556267
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
When Session.write_pandas is called with database= and schema= kwargs, _write_modin_pandas_helper builds a list like ["MY_DB", "MY_SCHEMA", "MY_TABLE"] and passes it as name to to_snowflake. The below-threshold path re-routes to the Snowflake backend which unpacks that list correctly. The Parquet path passed the whole list to a function that called .upper() on it.
write_pandas already accepts table_name, schema, and database as separate string arguments. So the #fix splits the list before calling it: last element is always the table name, second-to-last is the schema (if present), first is the database (if 3 parts). Each part is individually converted from Snowflake identifier format to the plain string write_pandas expects.