feat: add review metadata to ufm sarif - #677
Open
cbill-s wants to merge 1 commit into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This comment has been minimized.
This comment has been minimized.
cbill-s
force-pushed
the
feat/add-review-metadata-to-ufm-sarif
branch
from
July 30, 2026 14:13
6ad6365 to
c876c48
Compare
PR Reviewer Guide 🔍
|
PeterSchafer
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add review metadata to ufm sarif
Checklist
make test)make generate)make lint)go get github.com/snyk/go-application-framework@YOUR_LATEST_GAF_COMMITin thecliv2directory.go.modto point to your local GAF code.go mod tidyin thecliv2directory.go.modandgo.sumchanges.Note
Low Risk
Changes are additive SARIF fields and test API accessors with broad test coverage; no auth or runtime behavior changes beyond richer export metadata.
Overview
UFM SARIF output now includes policy rule review metadata on ignore suppressions when the applied policy rule was reviewed.
The test API client exposes
GetReviewedOnandGetReviewedByon ignore details (sourced from the policy rule’sreviewed_at/reviewed_by). The UFM SARIF template adds matchingreviewedOnandreviewedByfields in suppressionproperties, mirroring the existingignoredOn/ignoredByshape. Unreviewed ignores do not emit those keys.OpenAPI models and generated client code are updated for
PolicyRuleReviewerand rule review fields; a dedicated presenter test asserts valid JSON and the property bag (including comma handling in the template).Reviewed by Cursor Bugbot for commit c876c48. Bugbot is set up for automated code reviews on this repo. Configure here.