support to configure decompression buffer#188
Merged
Conversation
removed deprecated method which always support unlimited buffer, user can use decompressionBufferSize to set the limits
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a configurable WebSocket decompression buffer size: ChangesWebSocket Decompression Buffer Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
netty-socketio-core/src/main/java/com/socketio4j/socketio/BasicConfiguration.java (1)
76-78: ⚡ Quick winAdd JavaDoc and input validation for the new public API.
The setter lacks documentation explaining:
- What this parameter controls (WebSocket decompression buffer size limit)
- What the default value of
0means (unlimited? use Netty's default?)- What values are acceptable (positive integers only? any specific limits?)
Additionally, consider adding validation to reject invalid values such as negative numbers.
📝 Suggested documentation and validation
+ /** + * Set the maximum decompression buffer size for WebSocket compression. + * Used to limit memory consumption during WebSocket message decompression. + * <p> + * Default is <code>0</code> which means [specify: unlimited or use Netty default] + * + * `@param` decompressionBufferSize - buffer size in bytes, or 0 for [unlimited/default] + */ public void setDecompressionBufferSize(int decompressionBufferSize) { + if (decompressionBufferSize < 0) { + throw new IllegalArgumentException("decompressionBufferSize must be non-negative"); + } this.decompressionBufferSize = decompressionBufferSize; }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@netty-socketio-core/src/main/java/com/socketio4j/socketio/BasicConfiguration.java` around lines 76 - 78, Add JavaDoc to BasicConfiguration.setDecompressionBufferSize describing that this controls the WebSocket decompression buffer size limit, what a default of 0 means (e.g., unlimited or use Netty's default—state which), and the acceptable range (positive integers only). Add input validation in setDecompressionBufferSize to reject negative values (throw IllegalArgumentException with a clear message) and document the behavior for 0 and positive values; reference the field decompressionBufferSize and the setter setDecompressionBufferSize in the comment so reviewers can locate the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@netty-socketio-core/src/main/java/com/socketio4j/socketio/BasicConfiguration.java`:
- Around line 76-78: Add JavaDoc to
BasicConfiguration.setDecompressionBufferSize describing that this controls the
WebSocket decompression buffer size limit, what a default of 0 means (e.g.,
unlimited or use Netty's default—state which), and the acceptable range
(positive integers only). Add input validation in setDecompressionBufferSize to
reject negative values (throw IllegalArgumentException with a clear message) and
document the behavior for 0 and positive values; reference the field
decompressionBufferSize and the setter setDecompressionBufferSize in the comment
so reviewers can locate the change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c58faabb-e6c8-4788-a90d-517fbac10392
📒 Files selected for processing (2)
netty-socketio-core/src/main/java/com/socketio4j/socketio/BasicConfiguration.javanetty-socketio-core/src/main/java/com/socketio4j/socketio/SocketIOChannelInitializer.java
NeatGuyCoding
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed deprecated method which always support unlimited buffer, user can use decompressionBufferSize to set the limits
Description
Brief description of the changes in this PR.
Type of Change
Related Issue
Closes #(issue number)
Changes Made
Testing
mvn testChecklist
Additional Notes
Any additional information, screenshots, or context that reviewers should know.
Summary by CodeRabbit
New Features
Bug Fixes