Fix handling of Errno::ENODEV when getting terminal size#85
Merged
Conversation
When a terminal stream is re-opened to File::NULL, calling winsize raises Errno::ENODEV on macOS. Rescue it alongside Errno::ENOTTY and fall back to the default [24, 80] size. Co-authored-by: Cursor <cursoragent@cursor.com>
samuel-williams-shopify
force-pushed
the
fix-enodev-terminal-size
branch
from
c7d710d to
a986db5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Errno::ENODEValongsideErrno::ENOTTYinXTerm#size, so that streams re-opened toFile::NULLfall back to the default[24, 80]size instead of raising.Errno::ENOTTY(mocked) andErrno::ENODEV(using an actualFile::NULLstream).Test plan
bundle exec bake testpasses (147/147)Made with Cursor