Skip to content

Harden Accept header parsing - #109

Merged
samuel-williams-shopify merged 8 commits into
mainfrom
harden-accept-header-parsing
Jul 28, 2026
Merged

Harden Accept header parsing#109
samuel-williams-shopify merged 8 commits into
mainfrom
harden-accept-header-parsing

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add coverage for quoted parameters, malformed input, wildcards, and quality factors
  • support quoted pairs when splitting comma-separated media ranges
  • require complete parameter consumption and validate wildcard and q forms
  • preserve the existing regex-and-scan parser structure

Verification

  • bundle exec sus test/protocol/http/header/accept.rb
  • bundle exec bake test
  • bundle exec rubocop lib/protocol/http/header/accept.rb test/protocol/http/header/accept.rb
  • bundle exec bake decode:index:coverage lib

@samuel-williams-shopify
samuel-williams-shopify merged commit 787d6db into main Jul 28, 2026
34 of 46 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the harden-accept-header-parsing branch July 28, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant