Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Bring the work of SofaDefrost team on the official SofaQtQuick repository#34

Open
Ant0nin wants to merge 889 commits into
sofa-framework:masterfrom
SofaDefrost:dev
Open

Bring the work of SofaDefrost team on the official SofaQtQuick repository#34
Ant0nin wants to merge 889 commits into
sofa-framework:masterfrom
SofaDefrost:dev

Conversation

@Ant0nin
Copy link
Copy Markdown

@Ant0nin Ant0nin commented Jun 26, 2019

I am personally an everyday user of SofaQtQuick and I figured out that a lot of work has been done onto the next-gen GUI thanks to the Defrost team, especially @damienmarchal and @marques-bruno . For these reasons, I suggest to merge their "dev" branch onto the "master" branch of the official SofaQtQuick repository. Moreover, it seems that the merge can be performed in a fast-forward way so easy to do. What you guys do you think about?

@damienmarchal
Copy link
Copy Markdown
Contributor

This will break everyone's code as the dev branch involve major refactoring nearly everywhere.

@marques-bruno
Copy link
Copy Markdown
Member

I'd say it couldn't hurt to merge it in a dev branch or experimental branch on sofa-framework if people are interested to try it out and contribute to it, although that could be done through the SofaDefrost fork too. Our fork contains a lot of new contributions, that's true, but it also breaks a lot of stuff that were more or less working before, and there's been no attention dedicated to performances on our side so far... :)

@Ant0nin
Copy link
Copy Markdown
Author

Ant0nin commented Jun 26, 2019

@damienmarchal OK I didn't know that.
@marques-bruno I think that merging onto a dev branch of sofa-framework is a good idea. I already tried to contribute on SofaQtQuick ( see my PRs at https://github.com/sofa-framework/SofaQtQuick/pulls ) and I'll be glad to continue. Otherwise I can also directly use the dev branch of SofaDefrost repository if it is more convenient for you, and (re-)create my PRs on it.

damienmarchal and others added 27 commits November 6, 2019 23:01
Fix Saving of scene & Prefab
There is still one problem with FBO.
[runSofa2] Partially fix the EditView's rendering.
Refactor sofa scene fix camera view (Breaking)
marques-bruno and others added 30 commits March 24, 2020 17:50
Custom Asset template scripts in config/templates
     - Grid width adapting to zFar
     - Better Grid subdivision & rendering
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants