Repository navigation
Conversation
Every `$usage('uniform')` walked the schema and computed memory layouts to decide whether to warn about non-portable uniform alignment (`uniform-schema-misaligned`). That warning is off by default in production builds, so the work was wasted there.
- Adds `isEnabled(type)` to the internal logger, so callers can skip computing what a warning needs when it won't be shown.
- `warnIfNotUniformAligned` returns early when its warning is disabled. In development and tests nothing changes.
Node 22 with `NODE_ENV=production`, creating `root.createBuffer(Scene).$usage('uniform')` for a scene struct (camera matrices plus an array of 16 light structs). Medians of 9 fresh processes:
| | main | this PR |
|---|---|---|
| First buffer | 1.90 ms | 0.45 ms |
| Each of the next 200 | 69.2 µs | 3.8 µs |
There was a problem hiding this comment.
🟢 Approval recommended
The narrow guard matches the logger’s existing warning state and preserves enabled-warning behavior, with no unresolved findings.
No open issues 🎉
What changed in this PR
Avoids unnecessary uniform-alignment analysis when its warning is disabled, reducing buffer creation overhead in production.
Changes:
- Adds an internal logger method to query warning enablement.
- Skips alignment analysis when disabled, preserving existing behavior when enabled.
| File | Description |
|---|---|
| packages/typegpu/src/tgpuLogger.ts | Adds isEnabled() using existing warning state. |
| packages/typegpu/src/core/pipeline/webgpuLimitations.ts | Returns before alignment analysis when the warning is disabled. |
Review effort: Balanced
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
isEnabled(type)added to the internal logger.TgpuLogger.isEnabledmirrors the#enabledWarnings.has(type)guard already used bywarn/warnOnce; the method is only reachable through the unexported internalLoggerobject (logger), so no public API surface changes.- Early return in
warnIfNotUniformAligned. The alignment walk now exits before computing strides/layouts whenuniform-schema-misalignedis disabled. In DEV and tests all warnings are enabled, so the behavior and thetests/buffer.test.ts"Uniform alignment" snapshots are unchanged; in production the warning stays off and the analysis is skipped as intended.
The function has no side effects beyond warnings and TgpuLogger is the repo's only Logger implementation, so the added interface member has no other implementer to update.
deepseek-v4.1-flash (free via Pullfrog for OSS) ｜ 𝕏
| if (!logger.isEnabled('uniform-schema-misaligned')) { | ||
| // Silenced by default in production, and computing memory layouts isn't free | ||
| return; | ||
| } |
There was a problem hiding this comment.
very nit: If this check does not return, it is run for each of structs' props (this function is recursive)
There was a problem hiding this comment.
That's true, though the check is most likely very cheap, and only runs in dev mode anyway.
|
Moved to #3238 (branch now lives on the main repo instead of the fork). |
Every
$usage('uniform')walked the schema and computed memory layouts to decide whether to warn about non-portable uniform alignment (uniform-schema-misaligned). That warning is off by default in production builds, so the work was wasted there.isEnabled(type)to the internal logger, so callers can skip computing what a warning needs when it won't be shown.warnIfNotUniformAlignedreturns early when its warning is disabled. In development and tests nothing changes.Node 22 with
NODE_ENV=production, creatingroot.createBuffer(Scene).$usage('uniform')for a scene struct (camera matrices plus an array of 16 light structs). Medians of 9 fresh processes: