Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Renames the new v3 button-like component from Clickable to Touchable across the public v3 API surface, internal implementation, tests, and example app.
Changes:
- Rename exported component/type:
Clickable→Touchable,ClickableProps→TouchableProps - Update v3 barrel exports (
src/v3/index.ts,src/v3/components/index.ts) to expose the new names - Update tests and the common-app examples to use
Touchable
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-gesture-handler/src/v3/index.ts | Switches v3 public exports to Touchable / TouchableProps. |
| packages/react-native-gesture-handler/src/v3/components/Touchable/TouchableProps.ts | Renames the props type to TouchableProps. |
| packages/react-native-gesture-handler/src/v3/components/Touchable/Touchable.tsx | Renames the component and wrapper to Touchable. |
| packages/react-native-gesture-handler/src/v3/components/index.ts | Updates the v3 components barrel export from Clickable to Touchable. |
| packages/react-native-gesture-handler/src/v3/components/GestureButtons.tsx | Updates deprecation guidance strings to reference Touchable. |
| packages/react-native-gesture-handler/src/tests/api_v3.test.tsx | Updates component imports/usages and test descriptions to Touchable. |
| apps/common-app/src/new_api/index.tsx | Updates example registry entries/imports to the new touchable example modules. |
| apps/common-app/src/new_api/components/touchable/index.tsx | Renames example to use Touchable / TouchableProps and related identifiers/text. |
| apps/common-app/src/new_api/components/touchable_stress/index.tsx | Updates the stress test example to use Touchable and renamed identifiers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-native-gesture-handler/src/v3/components/GestureButtons.tsx
Outdated
Show resolved
Hide resolved
…eButtons.tsx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clickablewas initial name for our new component, but we all agreed that this name is not the best. SinceTouchablewas basically free - it was used with suffixes, likeTouchableOpacity, we decided to renameClickabletoTouchableTest plan
yarn ts-checkandyarn lint-js