Repository navigation
Default --db2 to the template database created by setup_databases.sh (#748) - #867
Open
AtharvaTilewale wants to merge 1 commit into
Open
AtharvaTilewale wants to merge 1 commit into
AtharvaTilewale wants to merge 1 commit into
Conversation
--use-templates 1 without --db2 left the template database as an empty path, so the existence check reported the confusing "Database . does not exist". Give --db2 the default name that setup_databases.sh creates, the same way --db1 and --db3 already have defaults. Fixes sokrypton#748
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
colabfold_search ... --use-templates 1without--db2fails witheven though the template database is present in the database directory (#748).
Root cause
--db1and--db3default to the database names thatsetup_databases.shcreates, but--db2defaulted toPath(""). With--use-templates 1that empty path is appended to the list of used databases and formats as., which produces the misleading error message. As noted in the issue thread, the template database simply had no default name.What the fix does
Give
--db2(and thetemplate_dbargument ofmmseqs_search_monomer) the defaultpdb100_230517, the namesetup_databases.shcreates, the same way--db1(uniref30_2302_db) and--db3(colabfold_envdb_202108_db) already have defaults.--use-templates 1now works without--db2, and if that database really is missing the error names it instead of..Validation
Added
tests/test_search.py, which runscolabfold_searchthroughmain()(withrun_mmseqsstubbed out) against a temp database directory holding only the UniRef stub files, and asserts the resultingFileNotFoundErrornames the template database.Pre-patch (
git stash push colabfold/mmseqs/search.py, test kept):Post-patch:
The 7 errors are
tests/test_colabfold.pyprediction tests, which need network access to download parameters/MSAs; they error identically on unmodifiedmainin this environment (baseline there is28 passed, 20 skipped, 7 errors).Fixes #748
Disclosure: this change was prepared with AI assistance and validated locally as described above.