fix(verify): drop --mount-path, note Apple Silicon build#100
Merged
Conversation
--mount-path program pointed at the program dir, but Cargo.lock lives at the workspace root, so solana-verify failed pre-flight with "Missing Cargo.lock". Mount the repo root (as CI's build-verified does) and select the program via --library-name. Document the Rosetta / DOCKER_DEFAULT_PLATFORM=linux/amd64 requirement for local verification on Apple Silicon, where the amd64-only verify image otherwise fails compiling getrandom for the SBF target.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--mount-path programfrom theverify-mainnetjustfile recipe.Cargo.locklives at the workspace root, not inprogram/, so solana-verify fails pre-flight withMissing Cargo.lock file. Mount the repo root (as CI's verifiable build does) and select the program via--library-name.DOCKER_DEFAULT_PLATFORM=linux/amd64. solana-verify pins Solana3.1.10to an amd64-only image and runsdocker runwith no--platform, so the SBF build fails compilinggetrandomunder arm64 emulation otherwise.Test Plan
export DOCKER_DEFAULT_PLATFORM=linux/amd64, runsolana-verify verify-from-repo(without--remote) against the program — builds clean, getrandom compiles.