Conversation
* feat: 지원 대학 존재 확인 메서드 추가 * feat: DTO, 도메인 메서드 추가 * feat: CUD 구현 및 테스트 코드 작성 * feat: CRUD 컨트롤러 작성 - 기존 벌크 insert 에 import 추가 * feat: 기존 지원 대학 검색 기능 확장 - 학기, 국내 대학 id 추가 * fix: 캐시 키에 빠진 파라미터 추가 * fix: soft delete된 지원서를 참조하는 경우에도 삭제되지 않도록 * refactor: List 원소 검증 추가 * refactor: PutMapping -> PatchMapping - 부분 수정 허용 * refactor: 코딩 컨벤션 리팩터링
whqtker
requested review from
Gyuhyeok99,
Hexeong,
JAEHEE25,
lsy1307,
sukangpunch and
wibaek
as code owners
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d808166b48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Integer studentCapacity, | ||
| SemesterAvailableForDispatch semesterAvailableForDispatch, |
There was a problem hiding this comment.
When an admin omits studentCapacity or semesterAvailableForDispatch (the new request accepts both as null, and the added tests exercise that path), the service stores nulls that public DTOs cannot handle: UnivApplyInfoPreviewResponse unboxes getStudentCapacity() to int, and UnivApplyInfoDetailResponse dereferences getSemesterAvailableForDispatch().getKoreanName(). A newly created current-term record with either field missing can therefore make search/detail endpoints return 500s until the data is repaired, so these fields should be validated as required or the public DTOs made null-safe.
Useful? React with 👍 / 👎.
| @DefaultCacheOut( | ||
| key = {"univApplyInfoTextSearch", "university:recommend:general"}, | ||
| cacheManager = "customCacheManager", |
There was a problem hiding this comment.
Updating an existing apply info only clears search/recommendation prefixes, but getUnivApplyInfoDetail is cached separately under univApplyInfo:{id} for 24 hours. If a user has opened the detail page before an admin changes capacity, requirements, or language scores, subsequent detail requests keep serving the stale cached response even though the update succeeded; evict the affected univApplyInfo:<id> key as the host-university update path already does for affected apply infos.
Useful? React with 👍 / 👎.
1 participant
No description provided.