Skip to content

fix: 메인 뉴스 조회에서 author-id 없이 전체 조회 적용 #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manNomi merged 1 commit into from
Feb 18, 2026
Merged

fix: 메인 뉴스 조회에서 author-id 없이 전체 조회 적용 #447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/web/src/apis/news/server/getNewsList.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ import type { ArticleListResponse } from "@/apis/news";
import type { News } from "@/types/news";
import serverFetch from "@/utils/serverFetchUtil";

const HOME_NEWS_AUTHOR_ID = 6;

export const getHomeNewsList = async (): Promise<News[]> => {
const response = await serverFetch<ArticleListResponse>(`/news?author-id=${HOME_NEWS_AUTHOR_ID}`);
const response = await serverFetch<ArticleListResponse>("/news");

@coderabbitai coderabbitai Bot Feb 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, explore the repository structure to understand the codebase layout
find . -type f -name "*.ts" -path "*/apis/*" | head -20

Repository: solid-connection/solid-connect-web

Length of output: 904

🏁 Script executed:

# Find the getNewsList.ts file and read its full content
cat -n apps/web/src/apis/news/server/getNewsList.ts

Repository: solid-connection/solid-connect-web

Length of output: 868

🏁 Script executed:

# Search for /news endpoint definition in the codebase
rg -n '"/news"' --type=ts -A 3 -B 1

Repository: solid-connection/solid-connect-web

Length of output: 1300

🏁 Script executed:

# Search for serverFetch utility to understand how it works
fd -e ts -e js -name "*serverFetch*" --exec cat {}

Repository: solid-connection/solid-connect-web

Length of output: 308

🏁 Script executed:

# Look for API endpoint definitions, especially for /news
find . -type f \( -name "*route*" -o -name "*api*" \) -path "*/news/*"

Repository: solid-connection/solid-connect-web

Length of output: 109

🏁 Script executed:

# Search for size/limit parameters in news-related API calls
rg -n 'size|limit' --type=ts -B 2 -A 2 | grep -A 3 -B 3 news

Repository: solid-connection/solid-connect-web

Length of output: 60

🏁 Script executed:

# Find serverFetchUtil - search for it in utils directory
find . -type f -name "*serverFetch*"

Repository: solid-connection/solid-connect-web

Length of output: 117

🏁 Script executed:

# Also search for the serverFetchUtil import location
rg -n "serverFetchUtil" --type=ts -B 1 | head -30

Repository: solid-connection/solid-connect-web

Length of output: 1551

🏁 Script executed:

# Look for backend/server API definitions (likely in a separate backend directory or api folder)
find . -type f \( -name "*.ts" -o -name "*.js" -o -name "*.py" \) | grep -E "(backend|server|api)" | grep -v node_modules | head -20

Repository: solid-connection/solid-connect-web

Length of output: 869

🏁 Script executed:

# Search for NewsController or news endpoint definition
rg -n "news" --type=ts -i | grep -iE "(controller|route|handler|endpoint)" | head -20

Repository: solid-connection/solid-connect-web

Length of output: 371

🏁 Script executed:

# Read the serverFetchUtil implementation
cat -n apps/web/src/utils/serverFetchUtil.ts

Repository: solid-connection/solid-connect-web

Length of output: 3456

🏁 Script executed:

# Look for backend structure - might be in a separate folder or monorepo
ls -la | grep -E "(backend|server|api)"

Repository: solid-connection/solid-connect-web

Length of output: 60

🏁 Script executed:

# Check if there's a backend directory at root level
find . -maxdepth 2 -type d -name "*backend*" -o -name "*server*" -o -name "*api*" 2>/dev/null | head -10

Repository: solid-connection/solid-connect-web

Length of output: 131

🏁 Script executed:

# Search for news-related controller or service definitions
rg -n "class.*News|function.*news" --type=ts -i | grep -v node_modules | head -20

Repository: solid-connection/solid-connect-web

Length of output: 789

🏁 Script executed:

# Check the api-schema package structure
ls -la packages/api-schema/

Repository: solid-connection/solid-connect-web

Length of output: 471

🏁 Script executed:

# Look for news-related API definitions in the packages
find packages/api-schema -type f \( -name "*.ts" -o -name "*.json" -o -name "*.yaml" -o -name "*.yml" \) | head -20

Repository: solid-connection/solid-connect-web

Length of output: 185

🏁 Script executed:

# Search for /news endpoint definition in the packages
rg -n '"/news"' packages/ --type=ts --type=json --type=yaml

Repository: solid-connection/solid-connect-web

Length of output: 60

🏁 Script executed:

# Also check bruno API files
find packages/bruno-api-typescript -type f -name "*.ts" | head -10

Repository: solid-connection/solid-connect-web

Length of output: 685

🏁 Script executed:

# Search for .bruno files which might contain API definitions
find . -name "*.bruno" -o -name "*.bru" 2>/dev/null | head -20

Repository: solid-connection/solid-connect-web

Length of output: 1176

🏁 Script executed:

# Search for ArticleListResponse type definition
rg -n "ArticleListResponse" --type=ts

Repository: solid-connection/solid-connect-web

Length of output: 2792

🏁 Script executed:

# Look for any API documentation or OpenAPI specs
find . -name "*.yaml" -o -name "*.yml" -o -name "*.json" | grep -iE "(openapi|swagger|api)" | head -10

Repository: solid-connection/solid-connect-web

Length of output: 665

🏁 Script executed:

# Check the git history to see if there was pagination parameter before
git log --oneline -20 -- apps/web/src/apis/news/server/getNewsList.ts 2>/dev/null || echo "Git history not available"

Repository: solid-connection/solid-connect-web

Length of output: 117

🏁 Script executed:

# Search for pagination-related patterns in news API responses
rg -n "page|limit|size|offset" --type=ts -B 2 -A 2 | grep -iA 3 -B 3 "news\|article" | head -40

Repository: solid-connection/solid-connect-web

Length of output: 60

🏁 Script executed:

# Read the ArticleListResponse definition and surrounding API code
cat -n apps/web/src/apis/news/api.ts

Repository: solid-connection/solid-connect-web

Length of output: 3985

/news 엔드포인트 호출 시 전체 뉴스 데이터 조회 범위 확인 필요

author-id 필터를 제거하면서 조회 범위가 단일 작성자에서 전체 뉴스 항목으로 확대되었습니다. 새로운 쿼리 파라미터 추가 없이 이루어진 변경으로, 홈페이지 렌더링 시 불필요한 성능 저하가 발생할 수 있습니다.

다음 사항을 확인해 주세요:

  1. 응답 타입 현황
    ArticleListResponse는 단순 배열 래퍼({ newsResponseList: Article[] })로, 페이지네이션 메타데이터(total, hasMore 등)가 포함되어 있지 않습니다.

  2. 권장 개선 방안
    백엔드에서 기본 페이지네이션 처리가 없다면, 다음과 같이 size 파라미터를 추가하는 것을 권장합니다:

수정 예시 
-  const response = await serverFetch<ArticleListResponse>("/news");
+  const response = await serverFetch<ArticleListResponse>("/news?size=10");
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const response = await serverFetch<ArticleListResponse>("/news");
const response = await serverFetch<ArticleListResponse>("/news?size=10");
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@apps/web/src/apis/news/server/getNewsList.ts` at line 6, The fetch in
getNewsList (serverFetch<ArticleListResponse>("/news")) now requests the entire
news set after removing the author-id filter while ArticleListResponse only
wraps newsResponseList and has no pagination metadata; update the call to
include a size (and optionally page) query parameter (e.g., append ?size=<N>) to
limit results and/or change the expected response shape to a paginated type (add
total/hasMore fields to ArticleListResponse) and adjust downstream consumers
that read newsResponseList so homepage rendering uses the limited list and
pagination metadata.


if (!response.ok) {
console.error("Failed to fetch home news list:", response.error);
Expand Down