-
Notifications
You must be signed in to change notification settings - Fork 3
fix: 앱 페이지 동작 버그 수정 #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+106
−6
Merged
fix: 앱 페이지 동작 버그 수정 #563
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| const KAKAO_OPEN_CHAT_HOST = "open.kakao.com"; | ||
| const KAKAO_OPEN_CHAT_PATH_PATTERN = /^\/o\/([^/?#]+)/; | ||
| const KAKAO_OPEN_CHAT_REFERER = "EW"; | ||
| const OPEN_CHAT_FALLBACK_DELAY_MS = 1200; | ||
|
|
||
| export const getKakaoOpenChatJoinScheme = (openChatUrl: string): string | null => { | ||
| try { | ||
| const url = new URL(openChatUrl); | ||
|
|
||
| if (url.hostname !== KAKAO_OPEN_CHAT_HOST) { | ||
| return null; | ||
| } | ||
|
|
||
| const linkId = url.pathname.match(KAKAO_OPEN_CHAT_PATH_PATTERN)?.[1]; | ||
|
|
||
| if (!linkId) { | ||
| return null; | ||
| } | ||
|
|
||
| return `kakaoopen://join?l=${encodeURIComponent(linkId)}&r=${KAKAO_OPEN_CHAT_REFERER}`; | ||
| } catch { | ||
| return null; | ||
| } | ||
| }; | ||
|
|
||
| export const openExternalUrl = (url: string) => { | ||
| const openedWindow = window.open(url, "_blank", "noopener,noreferrer"); | ||
|
|
||
| if (!openedWindow) { | ||
| window.location.href = url; | ||
| } | ||
| }; | ||
|
|
||
| export const openKakaoOpenChat = (openChatUrl: string) => { | ||
| const joinScheme = getKakaoOpenChatJoinScheme(openChatUrl); | ||
|
|
||
| if (!joinScheme) { | ||
| openExternalUrl(openChatUrl); | ||
| return; | ||
| } | ||
|
|
||
| let fallbackTimer: number | undefined; | ||
|
|
||
| const cleanup = () => { | ||
| if (fallbackTimer) { | ||
| window.clearTimeout(fallbackTimer); | ||
| } | ||
|
|
||
| window.removeEventListener("pagehide", cleanup); | ||
| document.removeEventListener("visibilitychange", handleVisibilityChange); | ||
| }; | ||
|
|
||
| const handleVisibilityChange = () => { | ||
| if (document.hidden) { | ||
| cleanup(); | ||
| } | ||
| }; | ||
|
|
||
| fallbackTimer = window.setTimeout(() => { | ||
| cleanup(); | ||
| openExternalUrl(openChatUrl); | ||
| }, OPEN_CHAT_FALLBACK_DELAY_MS); | ||
|
|
||
| window.addEventListener("pagehide", cleanup); | ||
| document.addEventListener("visibilitychange", handleVisibilityChange); | ||
|
|
||
| try { | ||
| window.location.href = joinScheme; | ||
| } catch { | ||
| cleanup(); | ||
| openExternalUrl(openChatUrl); | ||
| } | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this helper runs from a user click, such as a contact URL that does not match
open.kakao.com, passingnoopener,noreferrermakes a successfulwindow.openreturnnull, so this branch also navigates the current tab/WebView to the same URL. That regresses the previous_blanklink behavior by leaving My Page or opening the contact page twice even though the popup succeeded; use a popup-blocking check that does not rely on the handle returned whennoopeneris set.Useful? React with 👍 / 👎.