fix: 인기 파견학교 상세 링크 보정#566
Draft
manNomi wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
/university로 fallback하지 않도록 수정했습니다.homeUniversityName을 추천 응답 자체, 전체 학교 목록의 id 매칭, 학기+학교명 단일 매칭 순서로 보강하도록 했습니다.homeUniversityName을 반영했습니다.특이 사항
/university/{소속대학}/{학교id}형태로 렌더링되는 것을 확인했습니다./univ-apply-infos/search/text?value=API가 500Error during executeWithLock을 반환해 university-web build 단계에서 실패했습니다. 같은 이유로git push --no-verify로 브랜치를 올렸습니다.검증:
pnpm --filter @solid-connect/web run lint:checkpnpm --filter @solid-connect/web run typecheckpnpm --filter @solid-connect/university-web run lint:checkpnpm --filter @solid-connect/university-web run typecheckci:checkhttp://localhost:3000/HTML에서 인기 파견학교 카드 href 확인리뷰 요구사항 (선택)