fix: stop logging the client registration (it contains client_secret)#10
Merged
Conversation
ClientCredentialsTokenProvider.upgrade() console.log'd the oauth.Client object — including the client secret — into every consumer's console on every token mint. Debug leftover; removed.
There was a problem hiding this comment.
Pull request overview
Removes a debug console.log in ClientCredentialsTokenProvider.upgrade() that logged the OAuth client registration object, which included client_secret, preventing accidental secret exposure in consumer consoles.
Changes:
- Removed logging of
clientRegistrationfrom the client-credentials token mint flow to avoid leakingclient_secret.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
langsamu
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientCredentialsTokenProvider.upgrade()logged theoauth.Clientobject — includingclient_secret— to the console of every consumer on every client-credentials token mint (found while reviewing the Pod Manager's static bundle). Debug leftover; removed.tscbuild is clean.🤖 Generated with Claude Code