Skip to content

Fixed audio track and subtitle track issues in Android #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
naylinndev wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fixed audio track and subtitle track issues in Android #547

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c4b5e6d
fix(android): update library to support 16kb
Sep 1, 2025
11cead5
Merge branch 'master' into support_16kb
naylinndev Sep 1, 2025
fb58107
Fixed audio track and subtitle track issues in Android
Sep 26, 2025
cdb5dd3
Merge branch 'master' into support_16kb
naylinndev Sep 26, 2025
656d02b
Update DataSourceType.java
naylinndev Oct 11, 2025
1a8a098
Update DataSourceType.java
naylinndev Oct 11, 2025
be7bb9d
Update HwAcc.java
naylinndev Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions flutter_vlc_player/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ group 'software.solid.fluttervlcplayer'
version '1.0-SNAPSHOT'

buildscript {
ext.kotlin_version = "1.8.22"
ext.kotlin_version = "2.1.0"
repositories {
google()
mavenCentral()
Expand Down Expand Up @@ -50,7 +50,7 @@ android {
dependencies {
testImplementation("org.jetbrains.kotlin:kotlin-test")
testImplementation("org.mockito:mockito-core:5.0.0")
implementation 'org.videolan.android:libvlc-all:3.6.3'
implementation 'org.videolan.android:libvlc-all:4.0.0-eap21'
implementation 'androidx.appcompat:appcompat:1.7.0'
implementation 'androidx.legacy:legacy-support-v4:1.0.0'
implementation 'androidx.annotation:annotation:1.9.1'
Expand All @@ -62,7 +62,7 @@ android {

testLogging {
events "passed", "skipped", "failed", "standardOut", "standardError"
outputs.upToDateWhen { false }
outputs.upToDateWhen {false}
showStandardStreams = true
}
}
Expand Down
19 changes: 16 additions & 3 deletions ...lc_player/android/src/main/java/software/solid/fluttervlcplayer/Enums/DataSourceType.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,20 @@
package software.solid.fluttervlcplayer.Enums;

public enum DataSourceType {
ASSET,
NETWORK,
FILE

ASSET(0),
NETWORK(1),
FILE(2);

private int mType;

DataSourceType (int type)
{
this.mType = type;
}
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The constructor formatting is unconventional for Java. It's better to follow standard Java conventions for consistency and readability. Specifically, the space before the parameter list and the placement of curly braces can be improved.

    DataSourceType(int type) {
        this.mType = type;
    }

Copy link
Copy Markdown
Collaborator

@illia-romanenko illia-romanenko Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a reasonable comment - can we fix it?


public int getNumericType() {
return mType;
}

}
20 changes: 16 additions & 4 deletions flutter_vlc_player/android/src/main/java/software/solid/fluttervlcplayer/Enums/HwAcc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,20 @@
package software.solid.fluttervlcplayer.Enums;

public enum HwAcc {
AUTOMATIC,
DISABLED,
DECODING,
FULL

AUTOMATIC(-1),
DISABLED(0),
DECODING(1),
FULL(2);

private int mType;

HwAcc (int type)
{
this.mType = type;
}
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The constructor formatting is unconventional for Java. It's better to follow standard Java conventions for consistency and readability. Specifically, the space before the parameter list and the placement of curly braces can be improved.

    HwAcc(int type) {
        this.mType = type;
    }


public int getNumericType() {
return mType;
}
}
Loading
Loading