-
Notifications
You must be signed in to change notification settings - Fork 87
Add server-auxiliary-resources-management server-link-auxiliary-type #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2d13ea4
Add server-auxiliary-resources-management server-link-auxiliary-type
csarven 610b60f
Apply suggestions from code review
csarven 557abc4
Clarify server-auxiliary-resources-management
csarven accfea7
Make server-auxiliary-resources-management specifically about 'support'
csarven File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing this with @kjetil, I would just comment that the statement below does seem redundant:
When it says lifecycle I believe the only relevant part of the lifecycle is actually
DELETEand that requirement is already covered (for all auxiliary resources, not just those defined in the spec) by#server-delete-remove-auxilary-resource. If this is a non-normative comment to help understanding then it doesn't need to be part of the requirement statement where it could be perceived as adding to or amending the requirement. Perhaps it could be moved, and simplified to say something like:Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edwardsph , thanks. I agree (as discussed elsewhere) and updated the text as per your suggestion.
@kjetilk @RubenVerborgh Are we okay to merge this and close 371? This shouldn't drag out longer.
371 and 372 should stick to clarifying the current text / what was in our minds as opposed to introducing anything new or major changes (on auxiliary resources) - those can be in a different PR.