Open
Conversation
milomg
reviewed
Jun 22, 2022
| @@ -0,0 +1,109 @@ | |||
| /* | |||
| {{ | |||
There was a problem hiding this comment.
Maybe cite https://piccalil.li/blog/a-modern-css-reset/?
high1
reviewed
Jul 2, 2022
| import { Navbar } from './components/Navbar'; | ||
| import { Title } from './components/Title'; | ||
|
|
||
| const App: Component = () => { |
There was a problem hiding this comment.
I would argue that one common style should be used for Components, I think that export default function FunctionName is also used in the tutorial on site. So export default function App here?
high1
reviewed
Jul 2, 2022
| import logo from '../../logo.svg'; | ||
| import { SocialList } from '../SocialList'; | ||
|
|
||
| export default function () { |
There was a problem hiding this comment.
Maybe add a name to the function here, for consistency sake?
Collaborator
|
Mind resolving the merge conflict please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A demo showing a simple site built with (non stateful) components using SolidJS
Features:
src/index.css