fix: pagination keyboard controls#984
Conversation
🦋 Changeset detectedLatest commit: 2f8405f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying solid-primitives with
|
| Latest commit: |
2f8405f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eb045c13.solid-primitives.pages.dev |
| Branch Preview URL: | https://fix-pagination-keyboard-cont.solid-primitives.pages.dev |
When navigating the pagination with the keyboard, we could get into the situation where a button/link that previously had focus would be detached by the page switch, thus no longer having a parent reference to focus the current page. This is now fixed. Also, the stories broke whenever one switched the parameters. This is now rectified, too.
Addresses #286