Run pytest via the build interpreter to fix import failures#901
Draft
yungyuc wants to merge 1 commit into
Draft
Conversation
`make pytest` used the `py.test-3` launcher, whose shebang may bind to a different Python than the one that built the extension. Since `_modmesh` is ABI-tagged for the build interpreter, collection failed with "No module named '_modmesh'" whenever `py.test-3` resolved to another interpreter. Default `PYTEST` to "$(WHICH_PYTHON) -m pytest" so the runner matches the build interpreter. The variable stays overridable.
yungyuc
force-pushed
the
test/make-pytest
branch
from
514bbe7 to
b8ac779
Compare
tigercosmos
reviewed
Jun 16, 2026
| endif | ||
| # Test with the build interpreter; an ABI-tagged _modmesh cannot load under a | ||
| # py.test-3 launcher bound to a different Python. | ||
| PYTEST ?= $(WHICH_PYTHON) -m pytest |
Member
There was a problem hiding this comment.
I didn't realize this because I've already used python3 -m pytest to run tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pytestused thepy.test-3launcher, whose shebang may bind to a different Python than the one that built the extension. Since_modmeshis ABI-tagged for the build interpreter, collection failed with "No module named '_modmesh'" wheneverpy.test-3resolved to another interpreter.Default
PYTESTto "$(WHICH_PYTHON) -m pytest" so the runner matches the build interpreter. The variable stays overridable.