Add Chassis.get_cooling_type() API for liquid/air cooling detection#665
Open
shreyansh-nexthop wants to merge 1 commit into
Open
Add Chassis.get_cooling_type() API for liquid/air cooling detection#665shreyansh-nexthop wants to merge 1 commit into
shreyansh-nexthop wants to merge 1 commit into
Conversation
Signed-off-by: shreyansh-nexthop <shreyansh@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a generic
Chassis.get_cooling_type()API to ChassisBase so callers can ask "is this chassis liquid- or air-cooled?"COOLING_TYPE_LIQUID,COOLING_TYPE_AIR,COOLING_TYPE_UNKNOWN.COOLING_TYPE_UNKNOWN. Vendor Chassis subclasses override this to return the real value based on the platform signal.Motivation and Context
Required by the redfish feature in
sonic-buildimage- PR#27349-sonic-buildimage. The redfish docker should auto enable only on liquid-cooled BMC chassis.How Has This Been Tested?
Did manual verification by loading the image on the BMC Card.
Additional Information (Optional)