Add ChannelValue type for result and stdio channels#27
Open
martin-henz wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request transitions the communication channels for standard I/O and results from simple strings and any types to a structured ChannelValue interface, which includes a mandatory string representation and an optional rich payload. These changes affect the host and runner plugins as well as their respective interfaces. A minor suggestion was made to maintain alphabetical order in the type exports.
| export type { IErrorMessage } from "./IErrorMessage"; | ||
| export type { IIOMessage } from "./IIOMessage"; | ||
| export type { IResultMessage } from "./IResultMessage"; | ||
| export type { ResultPayload } from "./ResultPayload"; |
Contributor
There was a problem hiding this comment.
The export for ResultPayload is currently out of alphabetical order. To maintain consistency and improve readability, it should be moved after IStatusMessage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per discussion in "SA 2627 Conductor" telegram channel, this PR gets rid of "any" type in channel messages using a new ChannelValue type and provides a mandatory string field that lets the frontend display the value in a REPL.
This PR was created with the help of Claude Code (Opus 4.6).