Add conditional internal registry port (5000) to frontend service#869
Open
michaellzc wants to merge 2 commits into
Open
Add conditional internal registry port (5000) to frontend service#869michaellzc wants to merge 2 commits into
michaellzc wants to merge 2 commits into
Conversation
Adds configuration option `frontend.internalRegistry.enabled` to conditionally expose port 5000 as a named port "registry" on the frontend service and deployment. This supports the internal OCI image registry backed by blobstore for batch changes. https://claude.ai/code/session_016dk2KH5aCME6dzGTuyQzoG
Follows naming convention of other HTTP ports in the chart. https://claude.ai/code/session_016dk2KH5aCME6dzGTuyQzoG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/sourcegraph/sourcegraph/pull/12621
Summary
frontend.internalRegistry.enabledconfiguration option to conditionally expose port 5000 on the frontend serviceContext
This change enables exposing the internal image registry (go-containerregistry) running on port 5000 from the frontend service. This is needed to support batch changes that can build OCI images and publish them to an internal registry.
Slack thread: https://sourcegraph.slack.com/archives/C0A7PV1600P/p1779463759092779?thread_ts=1779268068.208029&cid=C0A7PV1600P
Usage
To enable the internal registry port:
Test plan
internalRegistry.enabled: false(default)internalRegistry.enabled: truehttps://claude.ai/code/session_016dk2KH5aCME6dzGTuyQzoG
Generated by Claude Code