Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
View all resources
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  GitHub Stars
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

sourcegraph / src-cli Public

Notifications You must be signed in to change notification settings
Fork 68
Star 321

Code
Issues 40
Pull requests 4
Actions
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Security
Insights

feature: Add support for HTTP_PROXY, HTTPS_PROXY, and NO_PROXY#1260

Draft

peterguy wants to merge 41 commits intomainsourcegraph/src-cli:mainfrom

peterguy/support-http_proxysourcegraph/src-cli:peterguy/support-http_proxyCopy head branch name to clipboard

Conversation Commits41 (41)Checks Files changed

Draft

feature: Add support for HTTP_PROXY, HTTPS_PROXY, and NO_PROXY#1260
peterguy wants to merge 41 commits intomainfrom
peterguy/support-http_proxy

Commits

Commits on Mar 27, 2026

fix formatting and error messages
peterguy
committed
add function to read HTTP_PROXY/HTTPS_PROXY/NO_PROXY environment variables
peterguy
committed
use new function to read proxy settings from environment, preferring SRC_PROXY if present
peterguy
committed
use http.Request instead of manually building the request, and use Request.Write to ensure correctness
peterguy
committed
commit to a buffered reader for the proxy connection so we avoid nasty edge cases of silently dropped/ignored pieces of the response from the proxy
peterguy
committed
clone the transport TLS config instead of creating a new one, and make sure it'll try HTTP/2 by setting NextProtos
peterguy
committed
fix some comments
peterguy
committed
whoops, forgot to commit the io import
peterguy
committed
dial the proxy, ensuring http/1.1 instead of http/2 for TLS-enabled proxy
peterguy
committed
add proxy tests
peterguy
committed
change name of test to match production method
peterguy
committed
add 10ms delay to test proxy server startup to try to fix ubuntu tests
peterguy
committed
go-lint.sh
peterguy
committed
wait for test proxy to startup
peterguy
committed
go-lint.sh
peterguy
committed
parse the endpoint into a URL up front, and gather the proxy from the env up front so that typos and malformed urls will surface immediately
peterguy
committed
use the parsed endpoint url and consolidate proxy handling because the proxy in the config is now the one gathered from either SRC_PROXY or the standard env variables
peterguy
committed
fix proxyDialAddr and add more tests for it
peterguy
committed
add EndpointURL to the tests and other places that should use it instead of Endpoint
peterguy
committed
use the client to connect to the API instead of http.DefaultClient so that proxies are used
peterguy
committed
restore unintentional whitespace changes
peterguy
committed
undo changes to search_jobs - do those changes in another PR
peterguy
committed
clarify comments and direct all proxy usage to the custom dialer
peterguy
committed
add a mutex for the buffered reader to match the concurency behavior of net.Conn.
peterguy
committed
close the connection if the TLS handshake errors
peterguy
committed
refactor to use httptest package
peterguy
committed
rename functions and address possible leaks
peterguy
committed
check I/O errors; use resp.ProtoMajor instead of strings
peterguy
committed
add test to confirm that closing the connection on handshake error (`tlsConn.Close()`) is necessary
peterguy
committed
fmt.Errorf --> errors.Newf
peterguy
committed
add test for https connection rejection - ensure correct error handling in the custom dialer
peterguy
committed
add retry for test that is flaky on CI, probably due to resource contention
peterguy
committed
another try at addressing CI test errors
peterguy
committed
clean up proxy and remove buffered reader - don't actually need it
peterguy
committed
clean up and refactor tests
peterguy
committed
refactor buildTransport to match incoming changes
peterguy
committed
fix error capitalization
peterguy
committed
undo capitalization change
peterguy
committed
fix rebase
peterguy
committed

Commits on Mar 28, 2026

remove the custom dialer - turns out it is not actually needed
peterguy
committed
remove unused function
peterguy
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.